Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix intermittent loading issue #714

Closed
wants to merge 1 commit into from
Closed

Fix intermittent loading issue #714

wants to merge 1 commit into from

Conversation

Schlickmann
Copy link

Hey folks, there is this bug reported here and I've been facing the same intermittently and debugging the project we found that the event listeners were being removed before the script finished loading.

Removing those lines of code the loading issue stops happening.

@vercel Vercel
Copy link

vercel bot commented Feb 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-google-charts-v2 ❌ Failed (Inspect) Feb 1, 2024 0:24am

@wavebeem
Copy link

wavebeem commented Feb 1, 2024

Hello! I was working on this with @Schlickmann and wanted to add my thoughts about the fix.

It's probably always the right thing to remove an event listener when a useEffect is done, but for some reason that's causing an infinite loading bug for us. I didn't understand the code well enough to pursue a more specific fix.

The "best" solution might be more involved than this, but this does seem to work. Additionally, I would think this won't leak very many event listeners, since subsequent loads will find the script tag already in the DOM. I would expect this to leak a finite amount of event listeners across repeated page navigation because of this.

@rakannimer
Copy link
Owner

Thank you for sending in this fix and for the analysis. Merging it to mitigate the issue for now. Will track the root-causing and providing the right solution separately.

rakannimer added a commit that referenced this pull request Sep 27, 2024
@rakannimer
fix: mitigates the infinite loading issue while the root cause is bei…
9957ab7 
…ng investigated

Addresses #710 #714

PR: #714
@rakannimer rakannimer closed this Sep 27, 2024
@rakannimer rakannimer mentioned this pull request Sep 27, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Schlickmann @wavebeem @rakannimer